Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touchpoints button padding #1464

Merged
merged 6 commits into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ ee: end-to-end-test
end-to-end-test: ## Run end-to-end tests in Cypress. (alias ee)
npx cypress run --project tests/e2e

eep: end-to-end-playwright
end-to-end-playwright: ## Run Playwright version of e2e tests
npx playwright test e2e/*

lt: load-time-test
load-time-test: ## Run page load time tests in Cypress (alias lt)
npx cypress run --project tests/load-times
Expand Down
23 changes: 23 additions & 0 deletions tests/playwright/e2e/touchpoints.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
const { test, expect } = require("@playwright/test");

const { describe } = test;

describe("Touchpoints button tests", () => {
describe("Basic layout", () => {

test("Touchpoints button is visible", async ({ page }) => {
await page.goto("http://localhost:8080/");
const button = await page.locator("a.touchpoints-button");

await expect(button).toBeVisible();
});

test("Does not occlude any links in the footer", async ({ page }) => {
await page.goto("http:localhost:8080/");
await page.evaluate(() => window.scrollTo(0, document.body.scrollHeight));
const footerLinks = await page.locator("footer a").last();

await expect(footerLinks).toBeVisible();
});
});
});
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% if page.footer %}
<footer role="contentinfo" class="margin-top-0">
<footer role="contentinfo" class="margin-top-0 padding-bottom-3">
<div class="usa-identifier">
<nav class="usa-identifier__section usa-identifier__section--required-links" aria-label="Important links,">
<div class="grid-container">
Expand Down
Loading