Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce spacing for alert county lists #1443

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Reduce spacing for alert county lists #1443

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
714b02e
Reduce spacing for alert county lists
partly-igor Jul 17, 2024
b0e250f
Test longer sleep to see if test failure goes away
partly-igor Jul 18, 2024
b0c2668
Merge branch 'main' into ik/alert-county-headers
loganmcdonald-noaa Jul 18, 2024
4436712
Merge branch 'main' into ik/alert-county-headers
loganmcdonald-noaa Jul 18, 2024
c0cc078
Revert sleep in action back to 10
partly-igor Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-site/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
# Give the containers a moment to settle.
- name: wait a tick
shell: bash
run: sleep 10
run: sleep 15
partly-igor marked this conversation as resolved.
Show resolved Hide resolved

- name: populate the site
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions web/themes/new_weather_theme/templates/block/block--weathergov-local-alerts.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@
{% if alert.alertAreas != false %}
{% for area in alert.alertAreas.countyAreas %}
<wx-alert-county-region>
<h5 class="wx-visual-h4 text-normal text-primary-dark">
<h5 class="wx-visual-h4 text-normal text-primary-dark margin-top-205 margin-bottom-0">
{{ "Counties in" | t }} {{ area.area }}
</h5>
<ul class="usa-list {%- if area.counties | length > 7 %} wx-col-2 {%- endif -%}">
<ul class="usa-list margin-top-1 {%- if area.counties | length > 7 %} wx-col-2 {%- endif -%}">
{% for county in area.counties %}
<li class="">{{ county }}</li>
{% endfor %}
Expand All @@ -81,10 +81,10 @@
{% endfor %}
{% if alert.alertAreas.cities %}
<wx-alert-cities>
<h5 class="wx-visual-h4 text-normal text-primary-dark">
<h5 class="wx-visual-h4 text-normal text-primary-dark margin-top-105 margin-bottom-0">
{{ "Including these cities" | t }} {{ area.area }}
</h5>
<ul class="usa-list {%- if alert.alertAreas.cities | length > 7 %} wx-col-2 {%- endif -%}">
<ul class="usa-list margin-top-1 {%- if alert.alertAreas.cities | length > 7 %} wx-col-2 {%- endif -%}">

{% for city in alert.alertAreas.cities %}
<li class="">{{ city }}</li>
Expand Down
Loading