Fixing Playwright tests / CI #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-gade
changed the title
loganmcdonald-noaa
approved these changes
Jul 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This PR updates our Playwright test config and CI config so that the browser e2e tests are sharded to run in parallel.
Previously, these tests were running serially and taking a long time to complete, which was holding up CI.
What does the reviewer need to know? 🤔
In addition to adding the correct configuration(s), we have also turned off testing in the Firefox browser. We have noticed that certain tests are -- unpredictably -- flaky when testing with firefox both locally and in CI.
A subsequent debt ticket will be created to look into why this is happening.