-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add impacted area square for hazard map legend #1430
Conversation
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Colors and legend are looking great, the only issue I am noticing is that on mobile the map has gotten a little squished (see screenshots below). I am guessing that the legend is counting in the aspect-ratio calculation? We want the map itself to be 3:2 (width:height), in the PR it's closer to 2.2:1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<div class="grid-container margin-top-2 padding-x-0 tablet:padding-x-2"> | ||
<div class="grid-container padding-0 wx-isolation-isolate grid-col-12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to move the wx-isolation-isolate
class from here and put it on the wx-alert-map
element
What does this PR do? 🛠️
Finishes #1355 by adding the small legend square.