Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add impacted area square for hazard map legend #1430

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

loganmcdonald-noaa
Copy link
Member

@loganmcdonald-noaa loganmcdonald-noaa commented Jul 11, 2024

What does this PR do? 🛠️

Finishes #1355 by adding the small legend square.

Screenshot 2024-07-11 at 1 20 03 PM

Copy link
Contributor

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

@loganmcdonald-noaa loganmcdonald-noaa changed the title [WIP] add impacted area square for hazard map legend add impacted area square for hazard map legend Jul 11, 2024
Copy link
Contributor

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

@loganmcdonald-noaa loganmcdonald-noaa marked this pull request as ready for review July 11, 2024 20:20
Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@partly-igor
Copy link
Collaborator

Colors and legend are looking great, the only issue I am noticing is that on mobile the map has gotten a little squished (see screenshots below). I am guessing that the legend is counting in the aspect-ratio calculation? We want the map itself to be 3:2 (width:height), in the PR it's closer to 2.2:1

PR
Screenshot of hazard map on design

beta
Screenshot of hazard map on beta

Copy link
Collaborator

@partly-igor partly-igor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good, the only thing I noticed with the last update is that the map control floating/z-index issue was reverted because the isolation class was removed. After that I think 👍

Adding screenshot to capture what I mean
Screenshot of floating controls


<div class="grid-container margin-top-2 padding-x-0 tablet:padding-x-2">
<div class="grid-container padding-0 wx-isolation-isolate grid-col-12">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to move the wx-isolation-isolate class from here and put it on the wx-alert-map element

@loganmcdonald-noaa loganmcdonald-noaa merged commit 8760a3a into main Jul 15, 2024
14 checks passed
@loganmcdonald-noaa loganmcdonald-noaa deleted the lmm/1355-hazard-map-legend-part-two branch July 15, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants