ADR for basic internationalization (1343) #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### Consequences | ||
| By using our own custom, separate module for storing and enabling our own translation files, we keep all the translation information in one place. Additionally, if we need to include any custom code and/or hooks for dealing with probable translation edge cases (think right-to-left languages or special character sets), we will already have a module where we can add that custom code. | ||
|
|
||
| The use of translation files allows us to store the translation in ur code repository and keep it versioned. It also allows us to programmatically track changes to any translations as we proceed. Additionally, we can later develop intergrated tests to make sure we are accounting for all text that should be translated, as well as pruning translations that are no longer used. |
There was a problem hiding this comment.
"our code repository"
|
Do we know exactly where the .po files will be stored? |
loganmcdonald-noaa
approved these changes
Jul 11, 2024
The files will live under our custom module where we store everything related to internationalization. Provisionally something like: |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This PR addresses #1343 by providing an ADR for how we will initially set up internationalization for static / templated text.
What does the reviewer need to know? 🤔
This is just the ADR. A follow-on PR will be filed that includes the initial implementation for English.