Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest CMI library #1426

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Update to latest CMI library #1426

merged 3 commits into from
Jul 15, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

  • Updates our libraries to point to the latest deployed version of the CMI library
  • Updates our local copy of the CMI CSS to the latest
  • Updates how we initialize the CMI component to include two new required settings (set to null since we don't use them, but they are required by schema validation)
  • Updates selector used to remove the menu from the DOM

What does the reviewer need to know? 🤔

If you pull it down locally, radar should work now.

@greg-does-weather
Copy link
Collaborator Author

I suggested we hold briefly on this. CMI will hopefully have a hotfix release in the near term that reverts the TILES vs. TILED change. As expected, it was a result in an update to the geoserver, but the TILES/TILED change was a bug. CMI was updated to mitigate the bug, but when the geoserver is fixed, CMI will be updated again.

We can check with Kari to see if there's an ETA on the geoserver fix. Unless we want to get a temporary fix up on beta sooner, in which case we can merge it and cut a release.

cc: @shadkeene @coreypieper

@greg-does-weather greg-does-weather removed the request for review from loganmcdonald-noaa July 12, 2024 16:54
@eric-gade eric-gade enabled auto-merge July 15, 2024 14:14
@eric-gade eric-gade merged commit 8176fe8 into main Jul 15, 2024
14 checks passed
@eric-gade eric-gade deleted the mgwalker/update-radar branch July 15, 2024 14:32
@colinmurphy01 colinmurphy01 mentioned this pull request Jul 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants