-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS flows #1314
CMS flows #1314
Conversation
@kmranjo This is ready for you to look at. I attached a video, and if you'd like to play around with it, I can deploy it into my environment. I think the only thing I did differently from the issue was combine the two help texts into one because it was easier, and once it was done I wasn't sure if it made sense to go back and split it up. (That is, the help text under the buttons says, "Content must be previewed before it can be saved or published." instead of having separate help text for each button.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for the flow charts too, that is a good way of communicating everything that I hadn't even tried.
$form["previewRequirement"]["notice"] = [ | ||
"#type" => "markup", | ||
"#markup" => | ||
"Content must be previewed before it can be saved or published.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should update this for the "Save updates as draft" flow to include some help text around how one gets a new version of a draft published... is it going to "Latest version" and changing the moderation state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvement! I reviewed the code and pulled down locally to test out. I think it's still a little funky when doing drafts/latest version publishing but we have a couple things to figure out there unrelated.
What does this PR do? 🛠️
Addresses #1266 by modifying the preview/save/publish flows and action buttons accordingly. It also adds additional text below the action buttons letting users know that they cannot save/publish until they have previewed.
Flows
Edit form action buttons
cms.flow.mov