Fix alert link styling #1303
Merged
Fix alert link styling #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partly-igor
approved these changes
Jun 10, 2024
| know what we're working with. The margin nudges the text down a bit so it | ||
| vertically aligns with the icon. | ||
| #} | ||
| class="line-height-sans-1 margin-top-05" |
There was a problem hiding this comment.
My suggestion is to change this to line-height-sans-2 to account for longer/wrapping text. At token 1 it gets a little tight for those cases
Token 1:
Token 2:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
The alert links in the hourly table were having their line heights set higher than default text, resulting in the text rendering slightly lower in the alert box in the hourly table than outside the table. This PR explicitly sets the line height on the alert link so it's consistent everywhere.
Screenshots (if appropriate): 📸