Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark color background to hero as fallback #1297

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

partly-igor
Copy link
Collaborator

What does this PR do? 🛠️

This PR adds an additional color background to the hero image so that the search box is visible before the image loads and as a fallback if it doesn't.

What does the reviewer need to know? 🤔

Screenshots (if appropriate): 📸

Normal loading

No image

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking! 👍

@partly-igor partly-igor merged commit 5be6d2c into main Jun 7, 2024
12 of 13 checks passed
@partly-igor partly-igor deleted the ik/hero-background branch June 7, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants