Document our contributed modules #1073
Conversation
| @@ -22,7 +22,6 @@ | |||
| "drupal/core-composer-scaffold": "^10.2", | |||
| "drupal/core-project-message": "^10.2", | |||
| "drupal/core-recommended": "^10.2", | |||
| "drupal/devel": "^5.1.2", | |||
There was a problem hiding this comment.
I've always been confused why we have both here and in dev-only 🤔 . Now that I'm thinking about it, it might not belong in dev, it might belong here but excluded via config_split?
There was a problem hiding this comment.
I'm genuinely not sure how this stuff got into our composer file in the first place. I think it was from a scaffold and we just never changed it. That said, what you've said here makes sense. The only reason I can think of for only having drupal/devel in the dev-only section is so it's not even installed in prod, and thus cannot possibly be exploited. But... I dunno how much of a concern that is?
| @@ -22,7 +22,6 @@ | |||
| "drupal/core-composer-scaffold": "^10.2", | |||
| "drupal/core-project-message": "^10.2", | |||
| "drupal/core-recommended": "^10.2", | |||
| "drupal/devel": "^5.1.2", | |||
There was a problem hiding this comment.
I'm genuinely not sure how this stuff got into our composer file in the first place. I think it was from a scaffold and we just never changed it. That said, what you've said here makes sense. The only reason I can think of for only having drupal/devel in the dev-only section is so it's not even installed in prod, and thus cannot possibly be exploited. But... I dunno how much of a concern that is?
|
|
||
| _Added in January 2024_ | ||
|
|
||
| We were looking for a way to disable certain modules locally (namely, samlauth and autologout) which only pertain to our cloud environments. We also wanted to set different configurations for autologout timing in beta than other cloud environments, fine tuning our settings for our production environment. This also allows us to restrict certain modules to dev-use only like `devel`. We could also use the `--no-dev` flag, but since the composer install in cloud.gov is not something we directly control, this flag is not used. `config_split` is the primary module for splitting configuration across environments. It required a complete reorganization of our configuration files. |
There was a problem hiding this comment.
Oh. So cloud.gov installs it anyway. Well then, seems like config-split makes the most sense then. 😂
loganmcdonald-noaa
force-pushed
the
lmm/1028-modules-docs
branch
from
d7592e7
to
f0070ed
Compare
What does this PR do? 🛠️
#1028
What does the reviewer need to know? 🤔
Not sure how useful the Github action actually is, and it won't catch dev-only modules. Those aren't the most important, but still nice to have information on.