Fix the timestamp in the screen reader narrative for current conditions #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-17
to
+23
| {{ content.temperature }}<span aria-hidden="true" class="font-body-xs display-inline-block left-full margin-top-05 margin-left-neg-2px">°F</span> | ||
| <span class="usa-sr-only">℉</span> | ||
| {{ content.temperature }}<span class="font-body-xs display-inline-block left-full margin-top-05 margin-left-neg-2px">°F</span> | ||
| </div> | ||
| <div class="margin-top-05 position-relative"> | ||
| <div class="font-mono-2xs font-family-mono text-base text-uppercase">{{ "Feels like" | t }}</div> | ||
| <div class="text-primary-darker"> | ||
| <p class="margin-top-2px font-body-md">{{ content.feels_like }} | ||
| <span aria-hidden="true" class="font-body-3xs position-absolute margin-top">°F</span> | ||
| <span class="usa-sr-only">℉</span> | ||
| <p class="margin-top-2px font-body-md"> | ||
| {{ content.feels_like }}<span class="font-body-3xs position-absolute margin-top">°F</span> |
There was a problem hiding this comment.
We don't need screen reader-specific handling here because these entire blocks are hidden from screen readers.
eric-gade
approved these changes
Apr 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
The timestamp in the screen reader narrative section of the current conditions component did not get updated when we switched how we do time localization. This PR fixes that.
Note
VoiceOver treats inline elements (like
spanortime) as independent blocks when reading them, so users must navigate to them individually. We cannot get around this. In Safari, addingrole="text"to the container element will force VoiceOver to treat it as a single block of text, but that's a nonstandard role and is ignored by all other browsers.I only have access to VoiceOver, so I cannot test this behavior with other screen readers, unfortunately, but the internet seems to think it should work as expected with them. VoiceOver is the oddball.