Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpoints button style fixes #1001

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Conversation

eric-gade
Copy link
Collaborator

@eric-gade eric-gade commented Apr 2, 2024

What does this PR do? 🛠️

This PR implements the changes asked for in #982, specifically:

  1. Ensuring that the touchpoints button is always on the top layer;
  2. Ensuring that the button has full width on mobile

What does the reviewer need to know? 🤔

Uses a mix of media queries and the existing utility classes (evdently the right-X and width-X utilities are not linked to the media query prefixes like mobile: etc in our current setup, so we had to adjust the custom styles sheet and add a class specifically for this button).

Screenshots (if appropriate): 📸

Mobile:

Screen Shot 2024-04-02 at 1 25 30 PM

Desktop:

Screen Shot 2024-04-02 at 1 25 39 PM

Copy link
Contributor

github-actions bot commented Apr 2, 2024

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually quite like it

@eric-gade eric-gade added this pull request to the merge queue Apr 6, 2024
Merged via the queue into main with commit cf4f939 Apr 6, 2024
11 checks passed
@eric-gade eric-gade deleted the eg-982-touchpoints-button-styling branch April 6, 2024 01:13
@colinmurphy01 colinmurphy01 changed the title Viewpoints button style fixes Touchpoints button style fixes Apr 11, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants