Merge pull request #1404 from weather-gov/mgwalker/1316-empty-nights

Filter out empty day periods

tests/api/data/testing/points/21.305,-157.858.json

@@ -1,6 +1,10 @@
 {
   "@bundle": {
-    "name": "has extra overnight period for today"
+    "name": "Honolulu, HI",
+    "attributes": [
+      "has preceding overnight period for today",
+      "has only day time period for 7th day (no night period)"
+    ]
   },
   "@context": [
     "https://geojson.org/geojson-ld/geojson-context.jsonld",

tests/playwright/e2e/daily-forecast.spec.js

@@ -0,0 +1,18 @@
+const { test, expect } = require("@playwright/test");
+
+const { describe, beforeEach } = test;
+
+describe("daily forecast", () => {
+  beforeEach(async ({ page }) => {
+    await page.goto("http://localhost:8081/play/testing");
+  });
+
+  test("does not display missing day periods", async ({ page }) => {
+    await page.goto("/point/21.305/-157.858");
+    const lastDay = page.locator(".wx-daily-forecast-block li").last();
+
+    const periods = lastDay.locator(".wx-daily-forecast-summary-area");
+
+    await expect(periods).toHaveCount(1);
+  });
+});

web/themes/new_weather_theme/templates/partials/daily-forecast-list-item.html.twig

@@ -49,7 +49,7 @@ only be a nighttime period.
       </div>
     </div>
     <div class="grid-row grid-gap">
-      {% for period in periods %}
+      {% for period in periods | filter(v => v) %}
         {% set marginUnit = 3 %}
         {% set tabletMarginUnit = 1 %}
         {% set tabletCol = 6 %}