Skip to content
This repository was archived by the owner on Jun 7, 2022. It is now read-only.

Conversation

@bia-wtag
Copy link

@bia-wtag bia-wtag commented Aug 6, 2021

Background

This module is not currently Drupal 9 compatible as shown in the upgrade_status report. For upgrading, the dependencies are updated, deprecated code was removed and info.yml was updated.

Goal

  • Module is D9 compatible.

Acceptance

  • Functionalities work.
  • No error from upgrade_status and d9 compatible.

Workflow

Local testing

Site Usable Link

@yobottehg
Copy link
Member

Just curious:
Are the changes from https://github.com/bmcclure/drupal-views_selective_filters/pull/4/files not needed?

@bia-wtag
Copy link
Author

bia-wtag commented Aug 6, 2021

Just curious:
Are the changes from https://github.com/bmcclure/drupal-views_selective_filters/pull/4/files not needed?

I am not quite sure. I haven't changed anything from .inc files as there seems to be no incompatible code.

Copy link

@zar-wtag zar-wtag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@yobottehg yobottehg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no actual clue if it will work but let's find out :)

@bia-wtag bia-wtag merged commit a204e7a into 8.x-1.x Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants