Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we only lint modified files? #391

Closed
risoms opened this issue Feb 6, 2022 · 2 comments
Closed

Can we only lint modified files? #391

risoms opened this issue Feb 6, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@risoms
Copy link

risoms commented Feb 6, 2022

Copied from #292. The need is definitely still there.

Did some research regarding #1 and found a GitHub action that helps with annotation via a .json file: https://github.com/Attest/annotations-action.

They just released a new version of runner that helps with composite actions https://docs.github.com/en/actions/creating-actions/about-actions#composite-run-steps-actions

But it's not fully ready to support calling an action within another action yet (which I think is the main reason we need the composite action though lol actions/runner#646 (comment)

Here are the next steps for composite actions: actions/runner#646

When expected action within action is released, we can leverage

file changes(conditional step, if to check for modified files or entire branch) https://github.com/trilom/file-changes-action
Run eslint and parse errors/warnings messages to follow https://github.com/Attest/annotations-action/blob/master/annotations.json (type definition: https://github.com/Attest/annotations-action/blob/master/src/annotation.ts)
Originally posted by @theoomoregbee in #47 (comment)

Is this issue still relevant today? Are we still waiting for github to release the functionality that enables us to lint only modified files?

@ocean90 ocean90 added the duplicate This issue or pull request already exists label Feb 20, 2022
@ocean90
Copy link
Member

ocean90 commented Feb 20, 2022

I have reopened #47 to keep the discussion in one place.

@ocean90 ocean90 closed this as completed Feb 20, 2022
@risoms
Copy link
Author

risoms commented Feb 20, 2022

@ocean90 It looks like although it's reopened, #47 is still locked from discussion.

There was an attempt to resolve this in #46 but work was paused before completion. The PR was then automatically closed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants