Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only lint modified files #1

Closed
samuelmeuli opened this issue Dec 22, 2019 · 1 comment
Closed

Only lint modified files #1

samuelmeuli opened this issue Dec 22, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@samuelmeuli
Copy link
Collaborator

Currently, all files in a repository are being linted. The action should detect which files are part of the relevant commit/PR and only check these files.

@samuelmeuli samuelmeuli added the enhancement New feature or request label Dec 22, 2019
@samuelmeuli samuelmeuli self-assigned this Dec 22, 2019
@samuelmeuli
Copy link
Collaborator Author

Unfortunately, there currently doesn't seem to be a simple way to implement this feature.

The problem is that the GitHub checks API only allows annotating commits, not pull requests. And if this feature were implemented for commits (only modified files in a commit would be linted/annotated), it would result in weird behavior on pull requests: If a user pushed another commit to an existing PR, only the files modified in that commit would be annotated. And because the GitHub UI only shows annotations for the most recent commit on a PR, the annotations would be incomplete.

@samuelmeuli samuelmeuli changed the title Only lint relevant files Only lint modified files May 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant