-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from Poetry to uv #81
Conversation
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]> Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
urllib3==1.26.19 ; python_version >= "3.11.dev0" and python_version < "3.12.dev0" | ||
uvicorn[standard]==0.21.1 ; python_version >= "3.11.dev0" and python_version < "3.12.dev0" | ||
uvloop==0.17.0 ; (sys_platform != "win32" and sys_platform != "cygwin") and platform_python_implementation != "PyPy" and python_version >= "3.11.dev0" and python_version < "3.12.dev0" | ||
virtualenv==20.23.1 ; python_version >= "3.11.dev0" and python_version < "3.12.dev0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Risk: Affected versions of virtualenv are vulnerable to Improper Neutralization of Special Elements used in a Command ('Command Injection') / Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection'). virtualenv
allows command injection through the activation scripts for a virtual environment. Magic template strings are not quoted correctly when replacing.
Fix: Upgrade this library to at least version 20.26.6 at llm-gateway/requirements.dev.txt:70.
Reference(s): GHSA-rqc4-2hc7-8c8v, CVE-2024-53899
💬 To ignore this, reply with:
• /fp <comment>
for false positive
• /ar <comment>
for acceptable risk
• /other <comment>
for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by ssc-9be743e1-05bf-d877-55ed-816b77b3322e.
README.md
Outdated
Example output: | ||
|
||
``` | ||
Finding: aws_secret="AKIAIMNOJVGFDXXXE4OA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue, but thinks it may be safe to ignore.
AWS Access Key ID Value detected. This is a sensitive credential and should not be hardcoded here. Instead, read this value from an environment variable or keep it in a separate, private file.
Why this might be safe to ignore:
The finding is in a test file (checks_test.go), which suggests it is not part of production code. Test files often contain hardcoded values for testing purposes, and this AWS Access Key ID is unlikely to be a real credential. Therefore, it is not a security risk in this context.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>
for false positive/ar <comment>
for acceptable risk/other <comment>
for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detected-aws-access-key-id-value.
You can view more details about this finding in the Semgrep AppSec Platform.
README.md
Outdated
--- a/checks_test.go | ||
+++ b/checks_test.go | ||
@@ -28,0 +37,1 @@ | ||
+ "aws_secret= \"AKIAIMNOJVGFDXXXE4OA\"": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue, but thinks it may be safe to ignore.
AWS Access Key ID Value detected. This is a sensitive credential and should not be hardcoded here. Instead, read this value from an environment variable or keep it in a separate, private file.
Why this might be safe to ignore:
The matched code is in a test file (checks_test.go), which suggests that this AWS Access Key ID is likely a placeholder or test value. Test files are not typically exposed to production environments, making this finding not reasonably exploitable.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>
for false positive/ar <comment>
for acceptable risk/other <comment>
for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detected-aws-access-key-id-value.
You can view more details about this finding in the Semgrep AppSec Platform.
README.md
Outdated
``` | ||
Finding: aws_secret="AKIAIMNOJVGFDXXXE4OA" | ||
RuleID: aws-access-token | ||
Secret AKIAIMNOJVGFDXXXE4OA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue, but thinks it may be safe to ignore.
AWS Access Key ID Value detected. This is a sensitive credential and should not be hardcoded here. Instead, read this value from an environment variable or keep it in a separate, private file.
Why this might be safe to ignore:
The matched code is in a test file (checks_test.go), which suggests it is not used in production. Test files often contain hardcoded values for testing purposes, and this AWS Access Key ID is unlikely to be a real credential.
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>
for false positive/ar <comment>
for acceptable risk/other <comment>
for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by detected-aws-access-key-id-value.
You can view more details about this finding in the Semgrep AppSec Platform.
wow! this is cool |
… monitoring Co-Authored-By: [email protected] <[email protected]>
…ectories Co-Authored-By: [email protected] <[email protected]>
Migrate from Poetry to uv
This PR migrates the project from Poetry to uv for dependency management, offering faster installation times and improved reproducibility.
Changes
Development Workflow Changes
uv pip install
instead ofpoetry install
uv venv
Docker Build Process Updates
--system
flag for uv installations in containersCI/CD Pipeline Updates
uv pip install --system
Testing
✅ Successfully tested:
uv venv
uv pip install
Link to Devin run: https://app.devin.ai/sessions/2430149b78eb49f6bff9c52e97afdb17
Requested by: [email protected]