fix: error on WC post template

[sapayth]

what if the Form Template is WooCommerce Template but the post type is post instead of product? added some checks for that.

related PR
fixes #611

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in the woo_attribute method to prevent undefined index notices.
• Improvements
  • Enhanced readability of the search method by renaming the parameter for better clarity.
  • Added validation to the name and is_visible fields in the woo_attribute method to ensure proper data handling.

[coderabbitai]

Walkthrough

The recent changes in the FieldableTrait.php file enhance method clarity and robustness. Notably, the search method's parameter name was updated for better readability, while the woo_attribute method now includes validation for fields to prevent errors from undefined indices. These improvements aim to bolster code maintainability and reduce potential runtime issues without modifying the core functionality.

Changes

Files	Change Summary
includes/Traits/FieldableTrait.php	Updated parameter name in search method for clarity; added validation logic for name and is_visible fields in woo_attribute method to enhance error handling.

Assessment against linked issues

Objective	Addressed	Explanation
Hide "Payment: Not Applicable" in Dashboard (#[611])	❌	Code changes do not address the visibility of the payment column.

A rabbit's delight in code so bright,
With clearer names and checks just right.
Hopping through traits, no errors in sight,
A smoother path, what a joyful sight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a363ec5 and 6f6526a.

Files selected for processing (1)

• includes/Traits/FieldableTrait.php (2 hunks)

Additional comments not posted (3)

includes/Traits/FieldableTrait.php (3)

699-699: Parameter Renaming Improves Readability

The parameter name change from $array to $the_array enhances readability. Ensure consistency throughout the method.

---

735-737: Improved Validation for Robustness

The added validation ensures that the name and is_visible fields are correctly populated, preventing errors from undefined indices.

---

705-713: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to search match the new parameter name.

Verification successful

---

Function calls to search are consistent with the new parameter names.

All instances of the search function calls in includes/Traits/FieldableTrait.php and includes/class-frontend-render-form.php use the correct parameter names.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `search` match the new parameter name.

# Test: Search for the function usage. Expect: Only occurrences of the new parameter name.
rg --type php -A 5 $'search'

Length of output: 35019

---

Script:

#!/bin/bash
# Description: Verify function calls to `search` in specific files.

# Test: Search for the function calls to `search` in the specified files.
rg --type php 'search' -A 5 includes/Traits/FieldableTrait.php includes/class-frontend-render-form.php

Length of output: 4140