fix: validate orderby and order input params #1464
Conversation
validate orderby and order input params for sorting a WP list table
WalkthroughThe recent updates to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant wpuf_get_completed_transactions
participant wpuf_get_pending_transactions
participant wpuf_get_all_transactions
User->>wpuf_get_completed_transactions: Call with args
wpuf_get_completed_transactions->>wpuf_get_completed_transactions: Validate `orderby` and `order`
wpuf_get_completed_transactions-->>User: Return array|string
User->>wpuf_get_pending_transactions: Call with args
wpuf_get_pending_transactions->>wpuf_get_pending_transactions: Validate `orderby` and `order`
wpuf_get_pending_transactions-->>User: Return array|int|void
User->>wpuf_get_all_transactions: Call with args
wpuf_get_all_transactions-->>User: Return array|int|void
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- wpuf-functions.php (5 hunks)
Additional comments not posted (5)
wpuf-functions.php (5)
2136-2142: Proper validation fororderbyandorderparameters.The validation logic for
orderbyandorderparameters ensures that only valid values are used, defaulting to 'id' and 'DESC' respectively if invalid values are provided.
2176-2182: Proper validation fororderbyandorderparameters.The validation logic for
orderbyandorderparameters ensures that only valid values are used, defaulting to 'id' and 'DESC' respectively if invalid values are provided.
2123-2124: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
wpuf_get_completed_transactionsmatch the new signature.
2243-2243: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
wpuf_get_all_transactionsmatch the new signature.
2163-2164: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
wpuf_get_pending_transactionsmatch the new signature.Verification successful
Function calls to
wpuf_get_pending_transactionsare consistent with the new signature.The following locations in the codebase have been verified:
includes/Admin/List_Table_Transactions.phplines 88, 237, and 259.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `wpuf_get_pending_transactions` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type php $'wpuf_get_pending_transactions'Length of output: 488
Script:
#!/bin/bash # Extract the lines where `wpuf_get_pending_transactions` is called in `includes/Admin/List_Table_Transactions.php` rg --type php --line-number wpuf_get_pending_transactions includes/Admin/List_Table_Transactions.phpLength of output: 353
Script:
#!/bin/bash # Extract context around the lines where `wpuf_get_pending_transactions` is called in `includes/Admin/List_Table_Transactions.php` rg --type php --context 5 --line-number wpuf_get_pending_transactions includes/Admin/List_Table_Transactions.phpLength of output: 2040
Rubaiyat-E-Mohammad
added
QA Approved
validate orderby and order input params for sorting a WP list table. details here.
for testers: please check the Transactions are showing, sorting properly in WP dashboard > WPUF > Transections menu
Summary by CodeRabbit
Bug Fixes
orderbyandorderparameters in transaction functions to prevent invalid values.Enhancements