Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce option to control if travel window closes on use of Esc or not #100

Closed
wduda opened this issue Jan 5, 2022 · 1 comment
Closed
Assignees

Comments

@wduda
Copy link
Owner

wduda commented Jan 5, 2022

Only just updated from the original plugin today. Thought this info might be useful for other people at the very least.

I want my Carousel of travel skills to be always visible, basically 2 conditions:
[LIST=1]
[]Travel Window doesn't hide after I use a Travel Skill
[
]Travel Window doesn't hide when I press Escape
[/LIST]

I would love if these could be options to set in the plugin, global positions/size/opacity settings would be nice too. Would also love if the carousel window could be just barely bigger than the skills displayed and didn't have a close button on it(while still being draggable), I'd want a way to disable resizing too but there's a setting for that in TraveWindow.lua. I'll probably just stumble around the lua files and figure it out on my own at some point. :D

[B][SIZE="3"]TravelCaroTab.lua[/SIZE][/B]
delete/comment out the red line, this stops the window closing when you use a travel skill.
[CODE] -- set the handler for mouse click events, show the menu
-- when right clicked
self.quickslots[i].MouseClick = function(sender, args)
if (args.Button == Turbine.UI.MouseButton.Right) then
Menu:ShowMenu();
else
[COLOR="Red"]self.parent:SetVisible(false);[/COLOR]
end
end[/CODE]

[B][SIZE="3"]TravelWindow.lua[/SIZE][/B]
Delete/comment out the red line, this will prevent the Main Window from closing when you press Escape
[CODE] -- manage hiding the UI
self.KeyDown = function(sender, args)
if (args.Action == Turbine.UI.Lotro.Action.Escape) then
[COLOR="Red"]self:SetVisible(false);[/COLOR]
self:CloseOptions();
self:CloseGondorMap();
self:CloseMoorMap();
self:CloseEriadorMap();
self:CloseRhovanionMap();
elseif (args.Action == 268435635) then
if (self.hidden == false) then
self.currentVisState = self:IsVisible();
self.hidden = true;
self:SetVisible(false);
self.ToggleButton:SetVisible(false);
else
self.hidden = false;
self:SetVisible(self.currentVisState);
self.ToggleButton:SetVisible(Settings.showButton == 1);
end
else
end
end[/CODE]

@wduda wduda self-assigned this Jan 5, 2022
@wduda wduda added this to the v1.0.19beta milestone Jan 5, 2022
@wduda wduda moved this to In Progress in Travel Window II Feb 7, 2022
@wduda wduda moved this from In Progress to Ready For Development in Travel Window II Feb 7, 2022
@wduda wduda moved this from Ready For Development to In Progress in Travel Window II Feb 7, 2022
@wduda wduda removed this from the v1.0.19beta milestone May 29, 2022
@wduda wduda moved this from In Progress to Ready For Development in Travel Window II Dec 31, 2023
@whiterabbit963 whiterabbit963 mentioned this issue Jan 8, 2024
whiterabbit963 added a commit to whiterabbit963/TravelWindowII that referenced this issue Jan 12, 2024
wduda pushed a commit that referenced this issue Jan 15, 2024
* add enable/disable all buttons

* add enable/disable overlapping skills buttons #171

* remove unnecessary args in MapWindow

* improve nil handling of location coordinate map

* update mapwindow after changing enable state

* optimize mass enable/disable update performance

* refactor TravelDictionary

Move all logic out of language files.
Replace global location variables with a single global: TravelInfo.
Update TravelDictionary counts on every AddSkill().
Minor simplification to TravelShortcut ctor.
Refactored several places where code was duplicated.
Removed broken and unnecessary handling of skills being removed from game.

* replace LC ints with turbine named constants

* add feature to ignore escape to close the main window #100

---------

Co-authored-by: whiterabbit963 <[email protected]>
wduda added a commit that referenced this issue Feb 20, 2024
* Features 171 and 100 (#172)

* add enable/disable all buttons

* add enable/disable overlapping skills buttons #171

* remove unnecessary args in MapWindow

* improve nil handling of location coordinate map

* update mapwindow after changing enable state

* optimize mass enable/disable update performance

* refactor TravelDictionary

Move all logic out of language files.
Replace global location variables with a single global: TravelInfo.
Update TravelDictionary counts on every AddSkill().
Minor simplification to TravelShortcut ctor.
Refactored several places where code was duplicated.
Removed broken and unnecessary handling of skills being removed from game.

* replace LC ints with turbine named constants

* add feature to ignore escape to close the main window #100

---------

Co-authored-by: whiterabbit963 <[email protected]>

* Mini UI option (#174)

* swap out silver window for a minimalist window

Includes icon snapping to ensure the window is always minimally sized.
Updated list, carousel, and pulldown tabs to be take up less room.

* move travel and settings data out of TravelWindow

The necessary logic is executed in Main.lua.
Many of the functions while no longer a part of TravelWindow still
remain in TravelWindow.lua and should be moved to more appropriate files.

* move functions out of TravelWindow

* add option to toggle between minwindow and the normal one

* remove mini-window padding

* minor spacement adjustment on pulldown tab

* remove SetWantsUpdates() on controls that do not use it

* add variable fade out speed to min opacity

* remove Turbine.UI.Extensions.Window dependency

* fixup pulldowntab opacity

---------

Co-authored-by: whiterabbit963 <[email protected]>

* Feature 101 (#175)

* handle empty case in the pulldown tab

* add feature #101

* put TravelWindow on top on TravelButton and cli

* Pulldown tab bug fixes (#176)

* fixup handling of deprecated buttonPositionX/Y

* fix pulldown tab issue for travel-on-click

Also fixes some scrolling issues for the drop down window.

* triple the fade-out duration

* Bug fix #177 (#178)

* make NextY() a local method to prevent misuse outside of intended scope

* fix string matching of skill descriptions

* allow options text to fill available space

* force mainwindow update when loading global settings

* change the default sort to put racial & class skills after general skills

This should improve level progression sorting.

* fixed syntax error in French dictionary

* minor translation cleanup

* removed unused code for unobtainable glan vraig maps

* fixes #179

* updated default readme

* adding new screenshots for lotrointerface.com

* add metadata for v2.0.0 release

---------

Co-authored-by: whiterabbit963 <[email protected]>
Co-authored-by: whiterabbit963 <[email protected]>
@wduda
Copy link
Owner Author

wduda commented Feb 20, 2024

v2.0.0

@wduda wduda closed this as completed Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Ready For Development to Done in Travel Window II Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant