readded unload event handling, added metadata

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
-v1.0.21beta
+## v1.0.23beta
+- saving options is now reliably done on every logout
+## v1.0.22beta
+- fixed bug with duplicate skillID affecting hunters trying to sort their travel skills
+- fixed TWII button not saving position when being moved
+- fixed error message when resetting skills to default
+## v1.0.21beta
 - added U34 skills for EN/DE/FR
 - fixed two Muster skills in DE
 - PluginManager button for options no longer opens a second copy of options window

TravelWindowII.plugin

@@ -3,7 +3,7 @@
     <Information>
         <Name>Travel Window II</Name>
         <Author>Hyoss</Author>
-        <Version>v1.0.22beta</Version>
+        <Version>v1.0.23beta</Version>
         <Description>
         This plugin creates a single window that contains all the available travel skills, including the race, class and reputation skills.
 It is a further development of Travel Window, that has been worked on by multiple authors before.

TravelWindowII.plugincompendium

@@ -2,7 +2,7 @@
 <PluginConfig xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <Id>1113</Id>
   <Name>Travel Window II</Name>
-  <Version>v1.0.22beta</Version>
+  <Version>v1.0.23beta</Version>
   <Author>Hyoss</Author>
   <InfoUrl>http://www.lotrointerface.com/downloads/info1113</InfoUrl>
   <DownloadUrl>http://www.lotrointerface.com/downloads/download1113</DownloadUrl>

doc/lotroforums.md

@@ -1,8 +1,6 @@
 A new version is available!
 
-v1.0.22beta
-- fixed bug with duplicate skillID affecting hunters trying to sort their travel skills
-- fixed TWII button not saving position when being moved
-- fixed error message when resetting skills to default
+v1.0.23beta
+- saving options is now reliably done on every logout
 
 Download it at [url=https://www.lotrointerface.com/downloads/fileinfo.php?id=1113]Lotrointerface[/url], [url=https://github.com/wduda/TravelWindowII/releases]GitHub[/url], via [url=https://github.com/JeremyStepp/OneLauncher]OneLauncher[/url] or via [url=https://www.lotrointerface.com/downloads/info663-LOTROPluginCompendium.html]Plugin Compendium[/url].

doc/lotrointerface.md

@@ -42,9 +42,7 @@ How to handle the settings reset introduced by v1.0.7beta?
 [/LIST]
 
 Version history:
-v1.0.22beta
-- fixed bug with duplicate skillID affecting hunters trying to sort their travel skills
-- fixed TWII button not saving position when being moved
-- fixed error message when resetting skills to default
+v1.0.23beta
+- saving options is now reliably done on every logout
 
 Rest of changelog found [URL="https://github.com/wduda/TravelWindowII/blob/master/CHANGELOG.md"]here[/URL].

src/Main.lua

@@ -1,21 +1,26 @@
 import "TravelWindowII.src";
 
 -- create the travel window
-travel = TravelWindow();
+_G.travel = TravelWindow();
+
+-- handle unload event and save settings
+plugin.Unload = function()
+    _G.travel:SaveSettings();
+end
 
 -- create a new command line command for the travel window
 TravelCommand = Turbine.ShellCommand();
 
 -- handle the travel commands
 function TravelCommand:Execute(command, arguments)
     if (arguments == "show") then
-        travel:SetVisible(true);
+        _G.travel:SetVisible(true);
     elseif (arguments == "hide") then
-        travel:SetVisible(false);
+        _G.travel:SetVisible(false);
     elseif (arguments == "toggle") then
-        travel:SetVisible(not travel:IsVisible());
+        _G.travel:SetVisible(not _G.travel:IsVisible());
     elseif (arguments == "dump") then
-        travel:DoDump();
+        _G.travel:DoDump();
     elseif (arguments ~= nil) then
         TravelCommand:GetHelp();
     end

src/SettingsMenu.lua

@@ -196,6 +196,5 @@ function SettingsMenu:Update(string)
 
     -- update the main window settings
     self.parent:UpdateSettings();
-    self.parent:SaveSettings();
 end
 

src/TravelButton.lua

@@ -90,7 +90,6 @@ function TravelButton:Constructor(parent)
                 Settings.buttonPositionX = one;
                 Settings.buttonPositionY = two;
                 self.mainWindow:UpdateSettings();
-                self.mainWindow:SaveSettings();
                 hasMoved = false;
                 self:SetBackColor(Turbine.UI.Color(0, 0.5, 0.5, 0.5));
 

src/TravelWindow.lua

@@ -166,7 +166,6 @@ function TravelWindow:Constructor()
         local one, two = self:GetPosition();
         Settings.positionX = one;
         Settings.positionY = two;
-        self:SaveSettings();
         self.PullTab:ClosePulldown();
     end
 
@@ -284,8 +283,6 @@ function TravelWindow:Constructor()
         Settings.width = self:GetWidth();
         Settings.height = self:GetHeight();
         self:UpdateSettings();
-        self:SaveSettings();
-
     end
 
     -- perform the resize
@@ -447,7 +444,6 @@ function TravelWindow:SaveMapHome(shortcut)
     end
     -- update and save everything
     self:UpdateSettings();
-    self:SaveSettings();
 end
 
 function TravelWindow:SetShortcuts()
@@ -652,7 +648,6 @@ end
 -- function to close the options window if it exists
 function TravelWindow:CloseOptions()
     if (self.options ~= nil) then
-        self:SaveSettings();
         self.options:SetVisible(false);
     end
     self.options = nil;