feat: add support for rendering within template element or shadowRoot #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
If one tries to use the
template
function within a template:This piece of code fails
storybook-helpers/src/html-templates.ts
Lines 327 to 331 in 9c67cc3
Because the
document.querySelector
will fail, given that the element will be generated within another document.Proposed solution
I don't think it's easily feasible to detect where a given component will render (especially with Storybook decorators), so instead, let's offer means for the consumer to "select" -up to a point1- the element containing either the ShadowDOM or DocumentFragment containing the element.
To keep things consistent, apply similar logic to the
window.component
feature.Footnotes
this won't work for level n2+ e.g.
<template><template>....finallyTemplate(args)....</template></template>
↩