Skip to content

Conversation

@leninalbertolp
Copy link

Collection of snippets for materializecss, complete and understandable, updated.

Is that there is already an equal to this plugin, but the existing 3 versions outdated regarding materializecss updates, I will make every effort to maintain my plugin updated and abreast with updates from materializecss.Add my plugin, materializecss snippets.

Sorry for my horrible English, is not my native language.

@leninalbertolp leninalbertolp changed the title Add Materilializecss Snippets Add Materializecss Snippets Jun 13, 2016
@FichteFoll
Copy link
Collaborator

FichteFoll commented Jun 13, 2016

Your package's name is too similar to "Materialized CSS Snippets".

Perhaps you can contribute to @ayinloya's package instead of adding your own and keep it up to date? It seems like he has been very open to PRs so far: https://github.com/ayinloya/materialized-css-snippets/pulls?q=is%3Apr+is%3Aclosed. Otherwise, if the packages serve different purposes, please explain the reason why you think adding your package's additions to the other package is undesirable.

@leninalbertolp
Copy link
Author

ok thanks, I'll put in contact to see how we can solve, I intend to keep my plugin updated and provide a good user experience.

The plugin built by @ayinloya this somewhat outdated regarding Materializecss Framework versions and many things have changed since then.

@FichteFoll
Copy link
Collaborator

@leninalbertolp any update?

@leninalbertolp
Copy link
Author

@FichteFoll excuse me for my bad English, it is not my native language.

I do not understand your question

@FichteFoll
Copy link
Collaborator

Were you able to get in contact with @ayinloya and did you work something out?

@leninalbertolp
Copy link
Author

@FichteFoll
If you talk to, respect the work of @ayinloya, I don't know, what other things have occupied their time, but there are three people working in its repository and at this point there are several outdated snippets of your project.

So I think, that they are not 100% committed to the project and I do not work that way.

Therefore, if you believe that my plugin can not enter Pakage control, because already there is the @ayinloya, you can close this pull.

@FichteFoll
Copy link
Collaborator

I do not intend to solve every conflict and I won't force people to collaborate when they don't want to (although I encourage them to do so), but your packacge names are still too simiar.

@ayinloya
Copy link
Contributor

ayinloya commented Jul 5, 2016

@FichteFoll , I'm always open to contributions. The materialized css snippits project is dependent on materializecss and has not been updated recently because there hasn't been much change. I believe @leninalbertolp's plugin can still be accepted under a different name if it's that different from the already existing one or @leninalbertolp you can let us merge the snippets that are up to date, I'm really ok with any of those options.

@leninalbertolp
Copy link
Author

@FichteFoll @ayinloya, I want to clarify some things, my intention is not to discredit the work of no one, and much less to say that my work is better. Only that, if I'm going to work with people, I like that they are committed to the project.

@ayinloya your repository has such outdated CDN snippets, the current version of materializecss is 0.97.6 and yours is still in version 0.97.3. Change a simple number does not take 1 minute. This is what I am referring to the commitment to the project. materializecss has also added a new card option.

I'm willing to work and contribute with you, my intention is provide to the community without search prominence.

@ayinloya I apologize if we begin with the left feet :) I will put in contact with you

@ayinloya
Copy link
Contributor

ayinloya commented Jul 5, 2016

@leninalbertolp , thanks for your consideration :) 👍

@wbond
Copy link
Owner

wbond commented Jul 18, 2016

So is collaboration happening on another package now? Should this PR be closed?

@leninalbertolp
Copy link
Author

if you can close this petition

@wbond wbond closed this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants