Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for 1.0.6 release #99

Closed
wants to merge 1 commit into from

Conversation

schmty
Copy link
Contributor

@schmty schmty commented Apr 19, 2019

This PR prepares the plyvel package for 1.0.6 which includes changes made in #97 resolving the OSX build issue detailed in #95

@wbolster
Copy link
Owner

thanks, looks good, i need to make some wheels and publish them when i merge this. will try to have a look soon

@wbolster
Copy link
Owner

wbolster commented May 2, 2019

thanks, news file was incomplete. used yours as a base and turned it into 1.1.0. which is now on pypi

@wbolster wbolster closed this May 2, 2019
@wbolster
Copy link
Owner

wbolster commented May 2, 2019

jfyi: as usual this took more effort than expected. there's a newer leveldb release since the previous plyvel release. this new version should be used in the linux wheels. but the dockerfile was failing after bumping the version. the download url changed. easy enough. but the build system changed as well, which needed some new configuration for the build to succeed.

🚀 🤖

@schmty
Copy link
Contributor Author

schmty commented May 2, 2019

Thanks for the feedback, I'll keep that in mind for future contributions 👍

@schmty schmty deleted the prepare-1.0.6-release branch May 2, 2019 23:46
@wbolster
Copy link
Owner

wbolster commented May 3, 2019

maintaining 30+ smallish oss projects requires many "simple" tasks but the context switching plus the many complications doing those (because computers hate me) basically mean that nothing is "just x" or "simply y".

"chores" contributions such as this pr actually help a lot. thanks! 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants