Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed conditional block in images building #919

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fixed conditional block in images building #919

merged 2 commits into from
Aug 3, 2023

Conversation

davidcr01
Copy link
Contributor

Description

Closes: #917
The aim of this PR is to remove the conditional block in the build-docker-images/build-images.sh script, which was useless.

if [ "$WAZUH_VERSION" -le "$WAZUH_CURRENT_VERSION" ]; then
  IMAGE_VERSION=${WAZUH_IMAGE_VERSION}
else
  IMAGE_VERSION=${WAZUH_IMAGE_VERSION}
fi

@davidcr01 davidcr01 linked an issue Aug 3, 2023 that may be closed by this pull request
Fix conditional block in build-image.sh script #917
Closed
2 tasks
@teddytpc1 teddytpc1 merged commit 32b1d88 into 4.5.2 Aug 3, 2023
@teddytpc1 teddytpc1 deleted the 917-fix-conditional-block-in-build-imagesh-script branch August 3, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bordon c-bordon c-bordon approved these changes

@teddytpc1 teddytpc1 teddytpc1 approved these changes

@vcerenu vcerenu Awaiting requested review from vcerenu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix conditional block in build-image.sh script
3 participants
@davidcr01 @teddytpc1 @c-bordon