Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate crossorigin option #20

Closed
jscheid opened this issue Nov 30, 2016 · 0 comments
Closed

Deprecate crossorigin option #20

jscheid opened this issue Nov 30, 2016 · 0 comments

Comments

@jscheid
Copy link
Collaborator

jscheid commented Nov 30, 2016

Webpack has an option output.crossOriginLoading used for loading chunks with code splitting. It's confusing that this plugin offers a similar option for use on asset tags generated by html-webpack-plugin. Starting with version 0.8.0, the webpack option is reused by default and the plugin option is deprecated.

To make code written for version 0.7.0 work without warnings in 0.8.0, ensure that the output.crossOriginLoading webpack option is set and that there is no crossorigin option in the plugin configuration.
jscheid added a commit that referenced this issue Nov 30, 2016
@jscheid
Deprecate crossorigin option
5bd2f2e 
- Default crossorigin option to webpack output.crossOriginLoading
- Warn when crossorigin option is passed
- Warn when output.crossOriginLoading is not set
- Error when output.crossOriginLoading is not set and code splitting is
  used

Closes #20
@jscheid jscheid mentioned this issue Nov 30, 2016
Merged
@XVincentX XVincentX mentioned this issue Dec 6, 2016
Merged
@bruno bruno closed this as completed in #21 Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jscheid