test: use anyio in async regression slice#288
Merged
janhilgard merged 1 commit intowaybarrios:mainfrom Apr 12, 2026
Merged
Conversation
janhilgard
approved these changes
Apr 12, 2026
Collaborator
janhilgard
left a comment
There was a problem hiding this comment.
LGTM. Clean test-only changes:
asyncio→anyiomarkers — broader backend compatibility, needed for Python 3.13+get_event_loop().run_until_complete()→asyncio.run()— the former is deprecated since 3.10 and removed from default behavior in 3.12+
No production code touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived from the current-main restack work for #226, but limited to the pushable test-side cleanup.
Changes:
@pytest.mark.anyioasyncio.get_event_loop().run_until_complete(...)withasyncio.run(...)in the API key testsWhy split this out:
.github/workflows/ci.yml) because GitHub requiresworkflowscope for OAuth-app pushes.Local validation:
PYTHONPATH=/Users/David/code/vllm-mlx-pr226-async-tests /opt/ai-runtime/venv-live/bin/python -m pytest /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_server.py -q -k "verify_api_key or reasoning_stream"PYTHONPATH=/Users/David/code/vllm-mlx-pr226-async-tests /opt/ai-runtime/venv-live/bin/python -m pytest /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_batching.py -q -k TestEngineAsyncPYTHONPATH=/Users/David/code/vllm-mlx-pr226-async-tests /opt/ai-runtime/venv-live/bin/python -m pytest /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_streaming_latency.py -q -k test_output_collectorPYTHONPATH=/Users/David/code/vllm-mlx-pr226-async-tests /opt/ai-runtime/venv-live/bin/python -m black --check --fast /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_batching.py /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_batching_deterministic.py /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_continuous_batching.py /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_server.py /Users/David/code/vllm-mlx-pr226-async-tests/tests/test_streaming_latency.pyRelated to #226.