fix(server): integrate tool call parser into reasoning parser streaming path#253
Merged
waybarrios merged 2 commits intowaybarrios:mainfrom Apr 11, 2026
Merged
Conversation
4bff328 to
89303c8
Compare
89303c8 to
1ce4107
Compare
waybarrios
reviewed
Apr 11, 2026
Owner
waybarrios
left a comment
There was a problem hiding this comment.
Clean fix for a real bug — tool calls were leaking as raw XML when the reasoning parser was active. The approach is correct and tests are solid.
One minor bug:
request.model vs _model_name inconsistency
The new tool_chunk in the reasoning path uses model=request.model, but every other chunk in the function (including the equivalent tool_calls chunk in the standard path) uses model=_model_name:
# New code (reasoning path):
tool_chunk = ChatCompletionChunk(
id=response_id,
model=request.model, # ← client-provided value
...
)
# Standard path (line ~2252) and all other chunks:
chunk = ChatCompletionChunk(
id=response_id,
model=_model_name, # ← actual served model name
...
)These can differ when --served-model-name is set. Should be _model_name for consistency.
Owner
|
Pushed a small fix (1d16507) — was using |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Qwen 3.5 model results in printing tool calls as raw xml and not applying actual tools.
Summary
tool_callschunks when parsed tool calls are detectedtool_callsfinish reason on the final streamed chunk when generation ends with parsed tool calls