feat: BatchedEngine parity — MTP routing, normalization, SpecPrefill#203
Closed
Thump604 wants to merge 1 commit intowaybarrios:mainfrom
Closed
feat: BatchedEngine parity — MTP routing, normalization, SpecPrefill#203Thump604 wants to merge 1 commit intowaybarrios:mainfrom
Thump604 wants to merge 1 commit intowaybarrios:mainfrom
Conversation
Port SimpleEngine features to BatchedEngine for continuous batching: - Per-request MTP routing: text-only → TextModel (MTP), media → MLLM - message_utils.py: shared _normalize_messages (developer→system, merge consecutive same-role, hoist system to [0]) - SpecPrefill config + draft model lifecycle in BatchedEngine - System KV cache with ChatML boundary detection Replaces PR waybarrios#192 (rebased against main after merge of waybarrios#180, waybarrios#97).
6 tasks
Collaborator
Author
|
Superseded by #204 (memory-aware scheduler includes BatchedEngine parity + admission control). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #192 (rebased against main after merge of #180, #97, #127).
Ports SimpleEngine features to BatchedEngine for continuous batching mode:
_normalize_messages()— maps developer→system, merges consecutive same-role messages, hoists system to position [0]. Required for Qwen 3.5 templates that reject malformed sequences.Context
PR #180 (SpecPrefill) merged SimpleEngine support. This PR extends the same features to BatchedEngine, which is the production path for continuous batching mode.
Test plan
--continuous-batching --enable-mtp --mllm_normalize_messagesprevents template crashes on malformed input