fix: rename platform.py to vllm_platform.py to avoid stdlib shadowing#185
Conversation
|
Clean fix. Shadowing The rename covers all the right spots:
One minor suggestion: you might consider keeping a thin +1 for merge. |
Thump604
left a comment
There was a problem hiding this comment.
Straightforward fix. stdlib shadowing causes real crashes with uvicorn. +1
|
Reviewed the change. The rename covers all import sites correctly: init.py, plugin.py, tests, and the entry point string goes through plugin.py so pyproject.toml is handled indirectly. No missed references. |
Brings in: prompt_tokens fix (waybarrios#236), ArraysCache batching (waybarrios#160), platform rename (waybarrios#185), mlx-lm 0.31 compat (waybarrios#183, waybarrios#227), base64 hash fix (waybarrios#206), streaming UTF-8 detokenizer (waybarrios#109), and cleanup commits. Conflicts resolved: - scheduler.py: keep make_logits_processors import (fork feature) - mllm_scheduler.py: take upstream stop-token skip in detokenizer - models/mllm.py: keep SHA256 hash (fork fix for collision) - utils/tokenizer.py: merge upstream error message with fork elif chain Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
platform.py shadows the stdlib module which causes a crash when running the server with uvicorn (which imports stdlib platform) added a prefix to resolve.