This repository was archived by the owner on Aug 6, 2024. It is now read-only.
New sleuth api for wavefront #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Feb 19, 2021
hanwavefront
suggested changes
Feb 24, 2021
Contributor
hanwavefront
left a comment
hanwavefront
left a comment
There was a problem hiding this comment.
A couple very minor nits, LGTM otherwise. Thanks!
...ot/src/main/java/com/wavefront/spring/autoconfigure/WavefrontTracingSleuthConfiguration.java
Outdated
Show resolved
Hide resolved
...g-boot/src/test/java/com/wavefront/spring/autoconfigure/WavefrontAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Applied the changes |
hanwavefront
approved these changes
Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change any Sleuth compliant tracer (Brave, OTel) can work with Wavefront out of the box (e.g.spring-projects-experimental/spring-cloud-sleuth-otel#16)