Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Detect solano-ci #9

Merged
merged 3 commits into from
Aug 14, 2018
Merged

[Feature] Detect solano-ci #9

merged 3 commits into from
Aug 14, 2018

Conversation

sibiraj-s
Copy link
Collaborator

@sibiraj-s sibiraj-s commented Jul 31, 2018

@sibiraj-s sibiraj-s changed the title [Feat] Detect gocd and solano-ci [Feat] Detect solano-ci Jul 31, 2018
Copy link
Owner

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this product better 💯

There's just one small nit that I would like to change (see code review comment), other than that it's all 👍👍👍😃

index.js Outdated
@@ -43,6 +44,7 @@ exports.isCI = !!(
env.CI || // Travis CI, CircleCI, Gitlab CI, Appveyor, CodeShip
env.CONTINUOUS_INTEGRATION || // Travis CI
env.BUILD_NUMBER || // Jenkins, TeamCity
env.TDDIUM || // Solano CI
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add TDDIUM to this list as it's taken care of by exports.name which will be set to Solano CI if the TDDIUM environment variable is present

@sibiraj-s
Copy link
Collaborator Author

👍 Updated.

@sibiraj-s sibiraj-s changed the title [Feat] Detect solano-ci [Feature] Detect solano-ci Aug 14, 2018
@watson watson merged commit e239e48 into watson:master Aug 14, 2018
@watson
Copy link
Owner

watson commented Aug 14, 2018

Released in version 1.2.0. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants