-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses TF_BUILD
in vendors.json
#116
Conversation
That's a better variable to use to detect whether this build is related to a pull request.
From a comment in another PR, it seems this is the more correct approach (versus #115). |
Thank you @jessehouwing . Can you add/fix tests as well? here https://github.com/watson/ci-info/blob/master/test.js#L126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Looks good.
Will merge and publish by tomorrow once tests are fixed
I'll nave to take a look, can't be too hard. Famous last words.
…On Tue, 3 Oct 2023, 15:34 Sibiraj, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Changes Looks good.
Will merge and publish by tomorrow once tests are fixed
—
Reply to this email directly, view it on GitHub
<#116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA724S4AYC4MWTBLEDCDI3LX5QH6HAVCNFSM6AAAAAA5P7XWCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJVGIZTCMBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It seems like the setup and teardown of the environment variables in the 'Azure Pipelines - PR' and 'Azure Pipelines - Not PR' tests needs to be updated. Looks straight-forward. |
Also tested in actual Azure Pipelines Build and PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks 🎉
Published in v3.9.0 |
See: https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml