Skip to content

Commit

Permalink
Merge bitcoindevkit#100: Remove some of the reserves and regtest feat…
Browse files Browse the repository at this point in the history
…ures

5b20283 update CI to remove some features (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Currently the way `ExternalReserves` functionality is written, it can only be used with `electrum` feature. The tests should fail if the implementation behavior is enforced.. Disabling the tests in CI.

  Also removing the `regtest-esplora` features from the tests, because they won't work when bitcoindevkit#92 lands.

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 5b20283.

Tree-SHA512: 09e875376e2a8b1a43c318b66849abdeb518deee32ca39ba1e10c9b9230b4af61a3391e5a1dcad0586643a820eb66fabfea9d2af95f0d97fe8383524c5e050d9
  • Loading branch information
notmandatory committed Jun 27, 2022
2 parents 80260e1 + 5b20283 commit 14866e2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/cont_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,10 @@ jobs:
- rpc
- reserves
- reserves,electrum
- reserves,esplora-ureq
- reserves,compact_filters
- reserves,rpc
- electrum,verify
# regtest-* features are experimental and not fully usable
- regtest-bitcoin
- regtest-electrum
- regtest-esplora-ureq
- regtest-esplora-reqwest

steps:
- name: Checkout
Expand Down

0 comments on commit 14866e2

Please sign in to comment.