Skip to content

Conversation

@yifanz0
Copy link

@yifanz0 yifanz0 commented Feb 3, 2023

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@blueww
Copy link
Member

blueww commented Feb 3, 2023

BTW, for the data need prepare:
Following looks a little duplicated (especially for the 2nd, we might don't want to keep 2 big files):

  1. testfile_10M , testfile_10240K_0
  2. testfile_300M, testfile_300000K_0

| testfile_1K_0 | 1KB |
| testfile_10M | 10M |
| testfile_300M | 300M |
| testfile_2048K | 2048K |
| testfile_10240K_0 | 10240K |
| testfile_300000K_0 | 300000K |

@yifanz0
Copy link
Author

yifanz0 commented Feb 3, 2023

@blueww Yes indeed. I'll address the duplicates in the next PR. 300M test file was added only for the blob copy cases to test block to block copy when size is bigger than 256M

@yifanz0 yifanz0 merged commit b03208a into regressiontests Feb 3, 2023
@blueww
Copy link
Member

blueww commented Feb 3, 2023

@blueww Yes indeed. I'll address the duplicates in the next PR. 300M test file was added only for the blob copy cases to test block to block copy when size is bigger than 256M

Thanks for the reply!
I think we just need to keep 1 test file > 256MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants