Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev excuse blog post #714

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Add dev excuse blog post #714

merged 3 commits into from
Sep 5, 2022

Conversation

maksim36ua
Copy link
Contributor

Description

Added a blog post for the dev excuse application. This PR includes a post and several images

Copy link
Contributor

@shayneczyzewski shayneczyzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a very nice blog post @maksim36ua! Great job! I particularly liked how each section heading looked like an excuse. :D I left a few comments. Unsure if you'd like another read by anyone or not but it seems almost ready to me.

One thing I definitely would recommend doing is removing the wasp-architecture.png image as it should already be there and called wasp-compilation.png.

@@ -0,0 +1,268 @@
---
title: Building a backbone for a full-stack web app with a single config file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the other titles do not end in punctuation. Maybe remove the period for consistency?

![Final result](../static/img/final-excuse-app.png)


## There’s an issue with the 3-rd party library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider changing 3-rd to third or 3rd.


Also, we’ve declared a database entity called `Excuse`, queries, and action. The `Excuse` entity consists of the entity’s ID and the text.

`Queries` are here when we need to fetch/read something, while `actions` are here when we need to change/update data. Both query and action declaration consists of two lines – a reference to the file that contains implementation and a data model to operate on. You can find more info in the docs. So let’s proceed with queries/actions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should link to those operations docs when we say "You can find more info in the docs"?

```js title=".../ext/queries.js | Defining queries"
import axios from 'axios';

export const getExcuse = async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note, in our internal code we are slowly shifting toward function statements vs arrow expressions, for reasons mentioned here: #487 More of just an FYI for future consistency 👍🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@shayneczyzewski shayneczyzewski self-requested a review September 5, 2022 16:40
Copy link
Contributor

@shayneczyzewski shayneczyzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me @maksim36ua 👍🏻 nice job!

@maksim36ua maksim36ua merged commit dd1dd42 into release Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants