Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Google as an Authentication method #669
Adds Google as an Authentication method #669
Changes from 95 commits
5229053
426d4c6
bb8010f
5b553eb
3422c3c
105b493
62496be
3850d44
2ddebff
37bd0cd
ed6e80e
97dd4a8
2ede79d
8e8d851
687d452
334213a
ec0c82e
e63da80
37626f3
fff55b3
2f4d119
7299586
dc6f5da
2b11028
bea4f6a
989fc54
40ed323
614ce1a
3f9b8c1
7026653
ac25be2
b5d6fb9
11bc0ae
b11d13a
3e1dc59
7418870
355ae4f
c239d58
af2120b
594a8dc
4f46a4c
2925c40
2b5578d
a66323b
5ec6cd8
a6ce30e
33855d7
5bcd59c
7d0f1f5
bbafa81
4aaa86b
3c5c5a8
980d811
7c97209
7c45bec
1d3f9bc
01a2650
9344a57
a6c590e
fb809d4
1c77b77
d853bb3
60368c0
67d478e
3763bef
b82330f
2c3db20
ac78c23
77c85ef
fa4fc62
93792bf
0689de7
a9d24ed
ae7adc0
583737e
edcf97a
87ba9ec
ca17358
8175e85
d1409ca
9ffcd5d
1ed1262
d6d0cb5
39a752c
7c42c5b
8e2fa3b
f7cdcd4
a5121ff
6cf621e
99ca0d3
35a8327
d896510
ede9a70
408856a
3b97481
2f7e14e
55323db
54fdb42
da3174b
aad6ad2
ce1dccb
ba9091e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have both of these functions, the one with dictionary and then also this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly to make it easier for the user to define a custom username strategy. It is shown in more detail for the Google profile
displayName
example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can do this filtering at Prisma level, with
select
or smth like that, so we maybe save some data transfer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean just
select
ing the username col, instead of returning the whole object? Yeah, we could. At max we will have just 10 results though, so I am not sure it would be a huge gain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, this "please contact Wasp" part is interesting :D. The Wasp shall help you :D!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was on the fence, but if that happens, we will know they are prob in the multiple million user range lol. Then we'd make the number of candidate usernames configurable/larger and make the random number suffix configurable/larger too. :D