Add rosetta detection #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Martinsos
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Great @kristian240 , this will be welcome addition!
Left some small comments.
| # check if rosetta is installed | ||
| pgrep -q oahd | ||
| if [ $? -ne 0 ]; then | ||
| info "We detected Apple Silicon without Rosetta installed. Make sure to install Rosetta due to compatibility - ${BOLD}softwareupdate --install-rosetta${RESET}" |
There was a problem hiding this comment.
Suggested change
| info "We detected Apple Silicon without Rosetta installed. Make sure to install Rosetta due to compatibility - ${BOLD}softwareupdate --install-rosetta${RESET}" | |
| info "We detected that you are on Apple Silicon (arm64) without Rosetta installed. Since Wasp binary is built for x86_64 and not for arm64, you will need to install Rosetta to use Wasp: ${BOLD}softwareupdate --install-rosetta${RESET} ." |
| @@ -66,6 +67,17 @@ get_os_info() { | |||
| esac | |||
| } | |||
|
|
|||
| check_for_rosetta() { | |||
There was a problem hiding this comment.
I would consider inlining this check inside of install_based_on_os, right after
"Darwin")
install_from_bin_package "wasp-macos-x86_64.tar.gz"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setup, check if apple silicon and no rosetta and log a note to user to install the rosetta.
Inspired by wasp-lang/wasp#1559