Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Split WASI unit tests into a separate executable #796

Merged
merged 1 commit into from
May 14, 2021

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented May 11, 2021

No description provided.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #796 (13995b6) into uvwasi_interface (99a9dfe) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           uvwasi_interface     #796   +/-   ##
=================================================
  Coverage             99.40%   99.40%           
=================================================
  Files                    80       80           
  Lines                 12524    12524           
=================================================
  Hits                  12449    12449           
  Misses                   75       75           
Flag Coverage Δ
rust 99.90% <ø> (ø)
spectests 90.54% <ø> (ø)
unittests 99.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests_wasi/wasi_test.cpp 98.24% <ø> (ø)

@axic
Copy link
Member

axic commented May 13, 2021

What is the reason for this?

@gumb0
Copy link
Collaborator Author

gumb0 commented May 14, 2021

What is the reason for this?

@chfast's point 2 here #790 (review)

@axic axic merged commit b07760f into uvwasi_interface May 14, 2021
@axic axic deleted the fizzy-unittests-wasi branch May 14, 2021 20:09
@gumb0 gumb0 mentioned this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants