Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: better OOM handling #788

Merged
merged 2 commits into from
Apr 20, 2021
Merged

capi: better OOM handling #788

merged 2 commits into from
Apr 20, 2021

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Apr 19, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #788 (81d3813) into master (81efc84) will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   99.25%   99.22%   -0.04%     
==========================================
  Files          79       79              
  Lines       12042    12060      +18     
==========================================
+ Hits        11952    11966      +14     
- Misses         90       94       +4     
Flag Coverage Δ
rust 99.87% <ø> (ø)
spectests 90.54% <ø> (ø)
unittests 99.17% <77.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/oom_test.cpp 88.09% <75.00%> (-8.06%) ⬇️
lib/fizzy/capi.cpp 97.56% <100.00%> (+0.01%) ⬆️

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, but not fully convinced we want to expose this as a separate error.

@gumb0 gumb0 marked this pull request as ready for review April 19, 2021 16:55
@gumb0 gumb0 requested a review from chfast April 19, 2021 16:55
@gumb0 gumb0 merged commit ece653a into master Apr 20, 2021
@gumb0 gumb0 deleted the capi-oom branch April 20, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants