Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix misuse of Vec where std::slice should be used and add tests for missing coverage #725

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

axic
Copy link
Member

@axic axic commented Feb 4, 2021

No description provided.

@axic axic requested review from gumb0 and chfast February 4, 2021 14:12
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #725 (f0eebd2) into master (a47029d) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   99.20%   99.34%   +0.13%     
==========================================
  Files          73       73              
  Lines       11110    11125      +15     
==========================================
+ Hits        11022    11052      +30     
+ Misses         88       73      -15     
Flag Coverage Δ
rust 99.78% <100.00%> (+3.34%) ⬆️
spectests 90.84% <ø> (ø)
unittests 99.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bindings/rust/src/lib.rs 99.78% <100.00%> (+3.34%) ⬆️

@axic axic changed the title rust: fix misuse of Vec where std::slice should be used and add more tests rust: fix misuse of Vec where std::slice should be used and add test for missing coverage Feb 4, 2021
@axic
Copy link
Member Author

axic commented Feb 4, 2021

I think now it should have complete coverage.

@axic axic requested review from gumb0 and chfast February 4, 2021 15:10
@axic axic changed the title rust: fix misuse of Vec where std::slice should be used and add test for missing coverage rust: fix misuse of Vec where std::slice should be used and add tests for missing coverage Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants