Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework testfloat test definitions in CMake #715

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Rework testfloat test definitions in CMake #715

merged 2 commits into from
Feb 2, 2021

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Feb 2, 2021

No description provided.

@chfast chfast requested review from axic and gumb0 February 2, 2021 13:53
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #715 (273cc28) into master (d2cc6d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          73       73           
  Lines       10885    10885           
=======================================
  Hits        10811    10811           
  Misses         74       74           
Flag Coverage Δ
rust 99.61% <ø> (ø)
spectests 90.84% <ø> (ø)
unittests 99.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fully understand the second commit, but the first seems to be okay and no test is lost.

@chfast chfast merged commit 83811a2 into master Feb 2, 2021
@chfast chfast deleted the testfloat branch February 2, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants