Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update spectests branch #690

Merged
merged 1 commit into from
Feb 17, 2021
Merged

ci: Update spectests branch #690

merged 1 commit into from
Feb 17, 2021

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Jan 12, 2021

This is to check new spec tests backported from wasm spec master.

Branch with new tests: wasmx/wasm-spec#2

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #690 (88f2cc8) into master (978073a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files          73       73           
  Lines       11388    11388           
=======================================
  Hits        11315    11315           
  Misses         73       73           
Flag Coverage Δ
rust 99.85% <ø> (ø)
spectests 91.08% <ø> (+0.23%) ⬆️
unittests 99.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gumb0 gumb0 force-pushed the update-spectests branch 3 times, most recently from f8f0b2b to 2b1abd8 Compare January 20, 2021 12:07
circle.yml Outdated
@@ -248,7 +248,7 @@ commands:
working_directory: ~/build
command: |
if [ ! -d wasm-spec ]; then
git clone https://github.com/wasmx/wasm-spec --branch w3c-1.0-tests-backported-20201113 --depth 1 wasm-spec
git clone https://github.com/wasmx/wasm-spec --branch w3c-1.0-tests-backported-fizzy-0.7.0 --depth 1 wasm-spec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed to use datestamp for the branches/tags, i.e. 3c-1.0-tests-backported-20210112 or whatever is the date of the last included commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a temporary branch that will be merged into w3c-1.0-tests-backported branch and then tagged w3c-1.0-tests-backported-<date> when we make a release (or could be earlier).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. I think we should aim to make a release next week.

@gumb0 gumb0 marked this pull request as ready for review February 12, 2021 17:13
@gumb0 gumb0 requested a review from chfast February 12, 2021 18:50
@gumb0 gumb0 merged commit 25205ab into master Feb 17, 2021
@gumb0 gumb0 deleted the update-spectests branch February 17, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants