-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add more tests for popcount #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cases with single bit are missing.
Same cases should be added to TEST(execute_numeric, i{32,64}_popcnt)
.
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
- Coverage 99.31% 99.31% -0.01%
==========================================
Files 72 72
Lines 10154 10148 -6
==========================================
- Hits 10084 10078 -6
Misses 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Added two single bit cases.
At this point though the tests should be changed to a pair then. |
Not sure what exactly do you mean, but you can create a new header file with test cases for struct BitCountTestCase64
{
uint64_t value;
uint32_t expected_clz;
...
};
constexpr BitCountTestCase64 test_cases_64[] = {{0,32,32,0}, ...};
|
Any more test cases to be added? |
Looks ok for now. |
1860a7b
to
01764c7
Compare
Also use these test cases in execute_numeric_test.
No description provided.