cmake: Remove redundant target_compile_features(... cxx_std_17) #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 71 71
Lines 9805 9805
=======================================
Hits 9736 9736
Misses 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. |
chfast
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
It has it here and is PUBLIC: https://github.com/wasmx/fizzy/blob/master/lib/fizzy/CMakeLists.txt#L7
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not needed, because
fizzylibrary includes it, as pointed out in #329 (comment)