test: Add more tests for call depth #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 71 71
Lines 9739 9805 +66
=======================================
+ Hits 9670 9736 +66
Misses 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
test_call_depth
branch
4 times, most recently
from
f208ad8 to
0056322
Compare
gumb0
reviewed
Dec 1, 2020
test/unittests/execute_call_test.cpp
Outdated
| auto i1 = instantiate(parse(wasm1), {}, {}, {}, {{&counter, {ValType::i64, true}}}); | ||
| counter.i64 = 0; | ||
| EXPECT_THAT(execute(*i1, 0, {}), Traps()); | ||
| EXPECT_EQ(counter.i64, MaxDepth + 1); // FIXME: Should be MaxDepth. |
There was a problem hiding this comment.
Why should it be? Function is executed MaxDepth + 1 times, because depth starts with 0 and ends with MaxDepth inclusive.
There was a problem hiding this comment.
Oh, this is correct, but I prefer there to be 2048 allowed calls, not 2049. This is changed in #669.
There was a problem hiding this comment.
I removed the FIXME comment as we have #669 to discuss it.
gumb0
reviewed
Dec 3, 2020
test/unittests/execute_call_test.cpp
Outdated
| EXPECT_EQ(counter, MaxDepth / 2 + 1); | ||
| } | ||
|
|
||
| TEST(execute_call, call_imported_interleaved_infinite_recursion_start_with_wasm) |
There was a problem hiding this comment.
I think this could have been just an additional execution in the previous test?
chfast
force-pushed
the
test_call_depth
branch
from
0056322 to
6d8e5b7
Compare
chfast
force-pushed
the
test_call_depth
branch
from
6d8e5b7 to
f126df0
Compare
gumb0
approved these changes
Dec 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.