capi: imported and exported tables #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 98.35% 98.36% +0.01%
==========================================
Files 69 69
Lines 9526 9592 +66
==========================================
+ Hits 9369 9435 +66
Misses 157 157 |
gumb0
force-pushed
the
capi-external-table
branch
3 times, most recently
from
0392a38 to
b0336db
Compare
gumb0
changed the title
gumb0
force-pushed
the
capi-external-table
branch
2 times, most recently
from
036b86a to
d8a6174
Compare
|
Rebased. |
| inline std::vector<fizzy::ExternalTable> unwrap(const FizzyExternalTable* external_table) | ||
| { | ||
| return external_table ? std::vector<fizzy::ExternalTable>{unwrap(*external_table)} : | ||
| std::vector<fizzy::ExternalTable>{}; |
There was a problem hiding this comment.
Cannot just {} work here? And same with {unwrap(...)}?
There was a problem hiding this comment.
No, error: initializer list cannot be used on the right hand side of operator '?'
| /// @param name The table name. NULL-terminated string. Cannot be NULL. | ||
| /// @param out_table Pointer to output struct to store found table. Cannot be NULL. | ||
| /// @returns true if table was found, false otherwise. | ||
| bool fizzy_find_exported_table( |
There was a problem hiding this comment.
I was going to say why isn't this grouped with find_exported_function, but realised that is over the module. This still confuses me in our API, both C++ and in C.
I think perhaps it would be clearer all these are instance related and later we could add some module inspection features.
There was a problem hiding this comment.
Yes, I put them separately, because this one operates on instance.
The change in #633 adds another fizzy_find_exported_function, that operates on instance and would be convenient, when you need to get an exported function and import it into another instance. With it there's going to be 4 similar fizzy_find_exported_* as in C++ API.
(However it has some complications with managing the lifetime of capture, so I'm not completely sure it's a good idea)
The function operating on module is renamed there to fizzy_find_exported_function_index, which better reflects what it does.
| (module | ||
| (func $f (export "foo") (result i32) (i32.const 42)) | ||
| (global (export "g1") i32 (i32.const 42)) | ||
| (table (export "tab") 10 30 anyfunc) |
There was a problem hiding this comment.
Perhaps add another table without a maximum?
gumb0
force-pushed
the
capi-external-table
branch
2 times, most recently
from
3e98f7e to
aca8ba0
Compare
gumb0
force-pushed
the
capi-external-table
branch
from
aca8ba0 to
3b51d9f
Compare
No description provided.