Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Move FP conversion tests to a separate file #623

Merged
merged 2 commits into from
Nov 3, 2020
Merged

test: Move FP conversion tests to a separate file #623

merged 2 commits into from
Nov 3, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Oct 23, 2020

After #618, GCC with sanitizer instrumentation goes OOM when compiling this file.

@chfast chfast force-pushed the test_split_fp branch 2 times, most recently from 59a74d3 to 2ea5479 Compare October 23, 2020 11:47
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited
Loading

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is 99.51%.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          67       69    +2     
  Lines        9535     9535           
=======================================
  Hits         9376     9376           
  Misses        159      159

@chfast chfast requested review from axic and gumb0 October 23, 2020 14:00
gumb0
gumb0 reviewed Oct 23, 2020
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
@chfast chfast requested a review from gumb0 November 2, 2020 14:11
@chfast
Copy link
Collaborator Author

chfast commented Nov 2, 2020

The relation to #618 is not important any more, but I still think this is useful because the execute_floating_point_test.cpp is one of the longest compiling file in the project.

axic
axic approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it was really just renaming the file and moving out a big block verbatim. Have not gone through the pain to verify it.

@axic axic merged commit c205fa6 into master Nov 3, 2020
@axic axic deleted the test_split_fp branch November 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

@gumb0 gumb0 gumb0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chfast @axic @gumb0