Convert instructions to vector<uint8_t> #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 67 67
Lines 9426 9429 +3
=======================================
+ Hits 9268 9271 +3
Misses 158 158 |
axic
reviewed
Oct 22, 2020
| @@ -362,7 +362,7 @@ struct Code | |||
|
|
|||
| // The instructions bytecode without immediate values. | |||
| // https://webassembly.github.io/spec/core/binary/instructions.html | |||
| std::vector<Instr> instructions; | |||
There was a problem hiding this comment.
Shouldn't we have a static_assert(sizeof(Instr) == sizeof(uint8_t)); in this file?
There was a problem hiding this comment.
This is not required because we don't reinterpret_cast<Instr*>(bytes_ptr) or the other way.
There was a problem hiding this comment.
Yeah though if it is not too much hassle having that extra assert could be helpful down the line, in case we mess it up somewhere.
There was a problem hiding this comment.
The enum class Instr : uint8_t is defined in this file.
There was a problem hiding this comment.
Oh right, lets hope the uint8_t is not removed :)
chfast
force-pushed
the
test_instructions_check
branch
from
5152ac9 to
d13addb
Compare
gumb0
approved these changes
Oct 22, 2020
axic
reviewed
Oct 22, 2020
axic
reviewed
Oct 22, 2020
axic
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to move immediate values to the same array later. That will increase overall performance.