Use proper feature test for C++20 std::span #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Oct 14, 2020
chfast
reviewed
Oct 15, 2020
The reason I put first in case we'd make the other things conditional based on the |
chfast
requested changes
Oct 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 63 63
Lines 9370 9370
=======================================
Hits 9206 9206
Misses 164 164 |
chfast
approved these changes
Oct 15, 2020
And make sure <version> is included in cxx20/bit.hpp.
gumb0
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://en.cppreference.com/w/cpp/utility/feature_test which sets
__cpp_lib_spanas an alias to201902L, while we were testing for201703L.